Skip to content

Conversation

@cezarbbb
Copy link
Contributor

@cezarbbb cezarbbb commented Nov 28, 2025

This is a test to detect the coexistence of 'stack-protector' and 'safe-stack', and it's a supplement to pr #147115 . After the solution to issue #149340, I rewrote a version using minicore to circumvent the 'abi_mismatch' error.

r? @SparrowLii (Do you have time to review it?)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 28, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@SparrowLii
Copy link
Member

@bors try jobs=test-various,x86_64-gnu-llvm-21-3

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 29, 2025
Test the coexistence of 'stack-protector' and 'safe-stack'

try-job: test-various
try-job: x86_64-gnu-llvm-21-3
@rust-bors
Copy link

rust-bors bot commented Nov 29, 2025

☀️ Try build successful (CI)
Build commit: d001e20 (d001e20c2c2a7526d0cb73f14617766ebd561500, parent: cc3eee7fbe17ea4b7238531cb97e1b7b8bd6afce)

@SparrowLii
Copy link
Member

r=me after squash the commits
@bors delegate+

@bors
Copy link
Collaborator

bors commented Nov 29, 2025

✌️ @cezarbbb, you can now approve this pull request!

If @SparrowLii told you to "r=me" after making some further change, please make that change, then do @bors r=@SparrowLii

@cezarbbb cezarbbb closed this Nov 29, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2025
@cezarbbb cezarbbb reopened this Nov 29, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2025
@SparrowLii
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2025
@SparrowLii

This comment was marked as duplicate.

@rust-bors

This comment was marked as duplicate.

@cezarbbb
Copy link
Contributor Author

@bors r=@SparrowLii

@bors
Copy link
Collaborator

bors commented Nov 29, 2025

📌 Commit 7c24c9a has been approved by SparrowLii

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 29, 2025

⌛ Testing commit 7c24c9a with merge 21e8591...

bors added a commit that referenced this pull request Nov 29, 2025
Test the coexistence of 'stack-protector' and 'safe-stack'

This is a test to detect the coexistence of 'stack-protector' and 'safe-stack', and it's a supplement to pr #147115 . After the solution to issue #149340, I rewrote a version using minicore to circumvent the 'abi_mismatch' error.

r? `@SparrowLii` (Do you have time to review it?)
@Zalathar
Copy link
Member

Yielding to enclosing rollup.

@bors retry

bors added a commit that referenced this pull request Nov 29, 2025
Rollup of 3 pull requests

Successful merges:

 - #144000 (Add `DefId::parent()` accessor for `rustc_public`)
 - #149409 (Test the coexistence of 'stack-protector' and 'safe-stack')
 - #149449 (Remove an unnecessary `unwrap` in `rustc_codegen_gcc`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4e3b7a1 into rust-lang:main Nov 29, 2025
11 of 12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 29, 2025
rust-timer added a commit that referenced this pull request Nov 29, 2025
Rollup merge of #149409 - cezarbbb:stable_ssp, r=SparrowLii

Test the coexistence of 'stack-protector' and 'safe-stack'

This is a test to detect the coexistence of 'stack-protector' and 'safe-stack', and it's a supplement to pr #147115 . After the solution to issue #149340, I rewrote a version using minicore to circumvent the 'abi_mismatch' error.

r? `@SparrowLii` (Do you have time to review it?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants